linux-kernel - Re: [PATCH] drm: Don't prepare or cleanup unchanging frame buffers [v2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 06 Aug 2016 22:26:09 -0700
From:	Keith Packard <keithp@...thp.com>
To:	Daniel Vetter <daniel@...ll.ch>
cc:	airlied@...ux.ie, keithp@...thp.com
Subject: Re: [PATCH] drm: Don't prepare or cleanup unchanging frame buffers [v2]

Daniel Vetter <daniel@...ll.ch> writes:

> Hm, I can't see v1 anywhere, but I think it'd be better. You can't store
> any transient state related to the current update in struct drm_plane. In
> this case the cleanup_buffers from a previous update might overlap (for
> nonblocking atomic commits) with the prepare_planes for the next one.
> Either we need special cleanup vs. error-path code, or some flag somewhere
> in the drm_plane_state.

Ok, here's pretty much the previous version, which works now that I've
fixed the intel driver. Instead of just comparing the fb's, I'm using
the framebuffer_changed function, which seems like a nice bit of
documentation if nothing else.


View attachment "0001-drm-Don-t-prepare-or-cleanup-unchanging-frame-buffer.patch" of type "text/x-diff" (2929 bytes)


-- 
-keith


Download attachment "signature.asc" of type "application/pgp-signature" (811 bytes)