linux-kernel - Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1470560360.2014.1.camel@suse.com>
Date:	Sun, 07 Aug 2016 10:59:20 +0200
From:	Oliver Neukum <oneukum@...e.com>
To:	Robert Foss <robert.foss@...labora.com>
Cc:	Ben Chan <benchan@...omium.org>, pprabhu@...omium.org,
	Guenter Roeck <groeck@...gle.com>, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

On Thu, 2016-08-04 at 13:44 -0400, Robert Foss wrote:
> 
> On 2016-08-03 06:39 AM, Oliver Neukum wrote:
> > On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote:

> > How can that depend on what we return to user space?
> > In the driver we can continue just ignoring errors.
> > Now, if user space stops reading because we reported an error,
> > that is the decision user space has made. We cannot ignore errors
> > in the kernel because we don't like what user space does when it
> > sees the error.
> 
> So perhaps the better solution is to be more intelligent about how 
> desc->rerr is written to during after an error to be able to maintain 
> the error condition?

Yes, good idea. I think an error condition should never be overwritten.
So we go to the current behaviour only if a second error before
user space has seen the3 first error arises. Would that fix your
issue?

	Regards
		Oliver