linux-kernel - [PATCH] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun,  7 Aug 2016 21:14:21 +0800
From:	Andy Yan <andy.yan@...k-chips.com>
To:	sre@...nel.org
Cc:	richard@....at, matthias.bgg@...il.com, moritz.fischer@...us.com,
	fengguang.wu@...el.com, alexandre.belloni@...e-electrons.com,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	dbaryshkov@...il.com, k.kozlowski@...sung.com, dwmw2@...radead.org,
	nicolas.ferre@...el.com, Andy Yan <andy.yan@...k-chips.com>
Subject: [PATCH] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM

Add missing HAS_IOMEM dependency for MFD_SYSCON to fix the um-allyesconfig
build error:

drivers/mfd/syscon.c: In function 'of_syscon_register':
drivers/mfd/syscon.c:67:9: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration]
  base = ioremap(res.start, resource_size(&res));
         ^
drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  base = ioremap(res.start, resource_size(&res));
       ^
drivers/mfd/syscon.c:109:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
  iounmap(base);
  ^

Signed-off-by: Andy Yan <andy.yan@...k-chips.com>
---

 drivers/power/reset/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index 7053abc..1388be3 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -190,6 +190,7 @@ config REBOOT_MODE
 config SYSCON_REBOOT_MODE
 	tristate "Generic SYSCON regmap reboot mode driver"
 	depends on OF
+	depends on HAS_IOMEM
 	select REBOOT_MODE
 	select MFD_SYSCON
 	help
-- 
2.7.4