linux-kernel - Re: [PATCH] scripts/Lindent: clean up and optimize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160807174849.1e30bef7@endymion>
Date:	Sun, 7 Aug 2016 17:48:49 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	Joe Perches <joe@...ches.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] scripts/Lindent: clean up and optimize

Hi Joe,

On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote:
> On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote:
> > * Add a few blank lines to improve readability.
> > * Don't call cut 3 times when once is enough.
> > * Drop a useless semicolon.
> 
> As it commonly reflows > 80 column code very badly,
> my preference would be to remove Lindent instead.
> 
> https://lkml.org/lkml/2013/2/11/390

This was 3.5 years ago, so apparently it's not happening.

Why don't you just remove -l80 from the options, if this is your only
concern with the script? Adding the appropriate option to indent to
support what we think is good would seem even better, but I do not have
any time to devote to this task.

-- 
Jean Delvare
SUSE L3 Support