linux-kernel - Re: [PATCH] mfd: arizona: Remove pointless switch case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 09:09:24 +0100
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Bernd Petrovitsch <bernd@...prog.at>
CC:	<lee.jones@...aro.org>, <patches@...nsource.wolfsonmicro.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: arizona: Remove pointless switch case

On Sat, Jul 23, 2016 at 07:41:13PM +0200, Bernd Petrovitsch wrote:
> Hi all!
> 
> On Fri, 2016-07-22 at 16:58 +0100, Charles Keepax wrote:
> [...]
> >  		case IRQF_TRIGGER_RISING:
> >  		case IRQF_TRIGGER_FALLING:
> >  			break;
> > -
> > -		case IRQ_TYPE_NONE:
> >  		default:
> 
> Don't know about the kernels coding rule in that case but personally, I
> use that style to explicit list all enum/#define values so that it is
> obvious that none was forgotten.
> For the compiler output, it shouldn't matter anyways ...
> 

I don't have any objection to dropping the patch as you say will
generate the same output either way.

Thanks,
Charles