linux-kernel - Re: [Intel-gfx] include/drm/i915_drm.h:96: possible bad bitmask ?

Open Source and information security mailing list archives

Date:	Mon, 8 Aug 2016 11:40:27 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	David Binderman <linuxdev.baldrick@...il.com>
Cc:	daniel.vetter@...el.com, jani.nikula@...ux.intel.com,
	David Airlie <airlied@...ux.ie>, dcb314@...mail.com,
	intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-gfx] include/drm/i915_drm.h:96: possible bad bitmask ?

On Mon, Aug 08, 2016 at 10:31:32AM +0100, David Binderman wrote:
> Hello there,
> 
> Recent versions of gcc say this:
> 
> include/drm/i915_drm.h:96:34: warning: result of ‘65535 << 20’
> requires 37 bits to represent, but ‘int’ only has 32 bits
> [-Wshift-overflow=]
> 
> Source code is
> 
> #define   INTEL_BSM_MASK (0xFFFF << 20)
> 
> Maybe something like
> 
> #define   INTEL_BSM_MASK (0xFFFFUL<< 20)
> 
> might be better.

Yup. Care to bake this into a patch (with s-o-b and everything per
Documentation/SubmittingPatches) so I can apply it?
-Daniel

> 
> 
> Regards
> 
> David Binderman
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives