linux-kernel - Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160808102834.GC10523@localhost>
Date:	Mon, 8 Aug 2016 12:28:34 +0200
From:	Johan Hovold <johan@...nel.org>
To:	"Sheng-Hui J. Chu" <s.jeffrey.chu@...il.com>
Cc:	linux-usb@...r.kernel.org, johan@...nel.org,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH v6] usb: serial: ftdi_sio Added 0a5c:6422 device ID for
 WICED USB UART dev board

On Thu, Jul 28, 2016 at 05:01:45PM -0400, Sheng-Hui J. Chu wrote:
> BCM20706V2_EVAL is a WICED dev board designed with FT2232H USB 2.0 UART/FIFO IC.
> 
> To support BCM920706V2_EVAL dev board for WICED development on Linux.  Add the VID(0a5c) and 
> PID(6422) to ftdi_sio driver to allow loading ftdi_sio for this board.
> 
> Signed-off-by: Sheng-Hui J. Chu <s.jeffrey.chu@...il.com>
> ---
>  drivers/usb/serial/ftdi_sio.c	   | 1 +
>  drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 0082080..ef19af4 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {
> 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
> 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
> 	{ USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
> +	{ USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
> 	{ }					/* Terminating entry */
>  };
>  
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index c5d6c1e..b29f280 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -1485,3 +1485,11 @@
>  #define CHETCO_SEASMART_DISPLAY_PID	0xA5AD /* SeaSmart NMEA2000 Display */
>  #define CHETCO_SEASMART_LITE_PID	0xA5AE /* SeaSmart Lite USB Adapter */
>  #define CHETCO_SEASMART_ANALOG_PID	0xA5AF /* SeaSmart Analog Adapter */
> +
> +/*
> + * WICED USB UART
> + */
> +#define WICED_USB_VID		0x0A5C
> +#define WICED_USB20706V2_PID	0x6422

This patch still failed to apply:

Applying: usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board
fatal: corrupt patch at line 11
Patch failed at 0001 usb: serial: ftdi_sio Added 0a5c:6422 device ID for WICED USB UART dev board

and checkpatch also complained about possible line wrapping.

I fixed it up here before applying, but next time please try sending the
patch to yourself and make sure it still applies before posting to the
list.

Thanks,
Johan