lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 8 Aug 2016 07:38:50 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] treewide: fix a bunch of typos (part 2)

On 08/07/16 22:20, Masahiro Yamada wrote:
> Hi Randy,
> 
> Thanks for taking a close look!
> 
> 
> 2016-08-08 13:50 GMT+09:00 Randy Dunlap <rdunlap@...radead.org>:
> 
>> --- a/net/sctp/transport.c
>> +++ b/net/sctp/transport.c
>> @@ -630,9 +630,7 @@ void sctp_transport_reset(struct sctp_transport *t)
>>         t->srtt = 0;
>>         t->rttvar = 0;
>>
>> -       /* Reset these additional varibles so that we have a clean
>> -        * slate.
>> -        */
>> +       /* Reset these additional variables so that we have a clean state. */
>>
>> * Nothing wrong with original comment.
> 
> 
> This hunk is doing three things:
> 
>  [1] varibles  -> variables
>  [2] slate   ->  state
>  [3] Make it into a single line
> 
> 
> Do you mean they are all unneeded changes?
> 

Sorry about that, I missed the varibles change. That change is correct.

The change of slate to state is not needed.

The single line change is OK also.

Thanks.


-- 
~Randy

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ