linux-kernel - [PATCH] Revert "of/irq: Mark initialised interrupt controllers as populated"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon,  8 Aug 2016 18:47:11 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	linux-kernel@...r.kernel.org
Cc:	kernel@...gutronix.de, Philipp Zabel <p.zabel@...gutronix.de>,
	Jon Hunter <jonathanh@...dia.com>,
	Rob Herring <robh@...nel.org>
Subject: [PATCH] Revert "of/irq: Mark initialised interrupt controllers as populated"

This reverts commit 15cc2ed6dcf91a8658e084be4e140147161819d7 ("of/irq:
Mark initialised interrupt controllers as populated"), which breaks the
i.MX6 GPC (General Power Controller). The GPC is both an interrupt
controller and a power domain controller. If the interrupt code sets the
OF_POPULATED bit early, the power domain driver is silently skipped, as
are the GPU and VPU drivers that are missing their power domain.

Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Jon Hunter <jonathanh@...dia.com>
Cc: Rob Herring <robh@...nel.org>
---
 drivers/of/irq.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 89a71c6..7d3f93f 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -559,8 +559,6 @@ void __init of_irq_init(const struct of_device_id *matches)
 			 * its children can get processed in a subsequent pass.
 			 */
 			list_add_tail(&desc->list, &intc_parent_list);
-
-			of_node_set_flag(desc->dev, OF_POPULATED);
 		}
 
 		/* Get the next pending parent that might have children */
-- 
2.8.1