linux-kernel - Re: [PATCH v3 2/9] usb: gadget: align buffer size when allocating for OUT endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 18:09:45 +0100
From:	Felipe Ferreri Tonello <eu@...ipetonello.com>
To:	kbuild test robot <lkp@...el.com>
Cc:	kbuild-all@...org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...nel.org>,
	Michal Nazarewicz <mina86@...a86.com>
Subject: Re: [PATCH v3 2/9] usb: gadget: align buffer size when allocating for
 OUT endpoint

Hi,

On 05-08-2016 20:15, kbuild test robot wrote:
> Hi Felipe,
> 
> [auto build test ERROR on balbi-usb/next]
> [also build test ERROR on v4.7 next-20160805]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Felipe-F-Tonello/Gadget-endpoint-request-allocation-and-MIDI/20160806-024520
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
> config: x86_64-randconfig-x013-201631 (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> Note: the linux-review/Felipe-F-Tonello/Gadget-endpoint-request-allocation-and-MIDI/20160806-024520 HEAD 5064a41cd5f89103e3b75c1a2ab9f6e98851503b builds fine.
>       It only hurts bisectibility.
> 
> All errors (new ones prefixed by >>):
> 
>>> drivers/usb/gadget/u_f.c:17:21: error: conflicting types for 'alloc_ep_req'
>     struct usb_request *alloc_ep_req(struct usb_ep *ep, int len, int default_len)
>                         ^~~~~~~~~~~~
>    In file included from drivers/usb/gadget/u_f.c:14:0:
>    drivers/usb/gadget/u_f.h:63:21: note: previous declaration of 'alloc_ep_req' was here
>     struct usb_request *alloc_ep_req(struct usb_ep *ep, size_t len, int default_len);

Ok, I made the mistake to change to size_t the len type just on the
function declaration. I'll fix this on a v4.

>                         ^~~~~~~~~~~~
> 
> vim +/alloc_ep_req +17 drivers/usb/gadget/u_f.c
> 
> 1efd54ea Andrzej Pietrasiewicz 2013-11-07  11   * published by the Free Software Foundation.
> 1efd54ea Andrzej Pietrasiewicz 2013-11-07  12   */
> 1efd54ea Andrzej Pietrasiewicz 2013-11-07  13  
> 1efd54ea Andrzej Pietrasiewicz 2013-11-07  14  #include "u_f.h"
> a7ffc68f Felipe F. Tonello     2016-08-05  15  #include <linux/usb/ch9.h>
> 1efd54ea Andrzej Pietrasiewicz 2013-11-07  16  
> 1efd54ea Andrzej Pietrasiewicz 2013-11-07 @17  struct usb_request *alloc_ep_req(struct usb_ep *ep, int len, int default_len)
> 1efd54ea Andrzej Pietrasiewicz 2013-11-07  18  {
> 1efd54ea Andrzej Pietrasiewicz 2013-11-07  19  	struct usb_request      *req;
> 1efd54ea Andrzej Pietrasiewicz 2013-11-07  20  
> 
> :::::: The code at line 17 was first introduced by commit
> :::::: 1efd54eab2b60c68c2ce75ea635306cef847d751 usb: gadget: factor out alloc_ep_req
> 
> :::::: TO: Andrzej Pietrasiewicz <andrzej.p@...sung.com>
> :::::: CC: Felipe Balbi <balbi@...com>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 

Felipe

Download attachment "0x92698E6A.asc" of type "application/pgp-keys" (7196 bytes)