linux-kernel - Re: [PATCH] Revert "Revert "doc/sphinx: Enable keep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160808153235.188f6d1d@lwn.net>
Date:	Mon, 8 Aug 2016 15:32:35 -0600
From:	Jonathan Corbet <corbet@....net>
To:	Daniel Vetter <daniel.vetter@...ll.ch>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Jani Nikula <jani.nikula@...el.com>,
	Markus Heiser <markus.heiser@...marIT.de>,
	Daniel Vetter <daniel.vetter@...el.com>
Subject: Re: [PATCH] Revert "Revert "doc/sphinx: Enable keep_warnings""

On Mon,  8 Aug 2016 18:23:11 +0200
Daniel Vetter <daniel.vetter@...ll.ch> wrote:

> Even with Markus fixes to the importer I still get warnigns from
> sphinx which are entirely bogus :(
> 
> /home/daniel/linux/src/Documentation/gpu/drm-kms.rst:13: WARNING: Could not lex literal_block as "C". Highlighting skipped.
> /home/daniel/linux/src/Documentation/gpu/drm-kms-helpers.rst:16: WARNING: Could not lex literal_block as "C". Highlighting skipped.
> /home/daniel/linux/src/Documentation/gpu/i915.rst:57: WARNING: Could not lex literal_block as "C". Highlighting skipped.
> 
> Well it's worse: Those are warnings which don't even show up with this
> enabled. Just sending this out again in the hopes some has a clue
> what's going on.

So I honestly think we should just set the highlight language to "none" by
default.  The syntax highlighting in code samples adds some colorful sugar
to the docs, but it's not really all that useful, IMO, and people who want
it can override the language in the right places.

Any strong opposition to this idea?

jon