linux-kernel - Re: [PATCH] staging: vt6655: power.c: Fix checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 08 Aug 2016 14:52:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Anson Jacob <ansonjacob.aj@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Forest Bond <forest@...ttletooquiet.net>,
	Kernel List <linux-kernel@...r.kernel.org>,
	Staging List <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] staging: vt6655: power.c: Fix checkpatch warning

On Mon, 2016-08-08 at 17:35 -0400, Anson Jacob wrote:
> Fix checkpatch.pl warning for trailing */ on a separate line
> Remove '+' postfix and '-' prefix from the start and end of block comments

Those /*+ uses should probably be converted to /** for kernel-doc

> Signed-off-by: Anson Jacob <ansonjacob.aj@...il.com>
> ---
>  drivers/staging/vt6655/power.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c
> index bc8ca98..7d6e746 100644
> --- a/drivers/staging/vt6655/power.c
> +++ b/drivers/staging/vt6655/power.c
> @@ -52,7 +52,7 @@
>  
>  /*---------------------  Export Functions  --------------------------*/
>  
> -/*+
> +/*
>   *
>   * Routine Description:
>   * Enable hw power saving functions
> @@ -60,7 +60,7 @@
>   * Return Value:
>   *    None.
>   *
> - -*/
> + */
>  
>  void
>  PSvEnablePowerSaving(
> @@ -104,7 +104,7 @@ PSvEnablePowerSaving(
>  	pr_debug("PS:Power Saving Mode Enable...\n");
>  }
>  
> -/*+
> +/*
>   *
>   * Routine Description:
>   * Disable hw power saving functions
> @@ -112,7 +112,7 @@ PSvEnablePowerSaving(
>   * Return Value:
>   *    None.
>   *
> - -*/
> + */
>  
>  void
>  PSvDisablePowerSaving(
> @@ -134,7 +134,7 @@ PSvDisablePowerSaving(
>  }
>  
>  
> -/*+
> +/*
>   *
>   * Routine Description:
>   * Check if Next TBTT must wake up
> @@ -142,7 +142,7 @@ PSvDisablePowerSaving(
>   * Return Value:
>   *    None.
>   *
> - -*/
> + */
>  
>  bool
>  PSbIsNextTBTTWakeUp(