linux-kernel - Re: [PATCH 0/7] Minor DP aux transaction fixes

Open Source and information security mailing list archives

Message-ID: <20160809061126.GF6232@phenom.ffwll.local>
Date:	Tue, 9 Aug 2016 08:11:26 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	Alex Deucher <alexdeucher@...il.com>
Cc:	Lyude <cpaul@...hat.com>, Tom St Denis <tom.stdenis@....com>,
	Jammy Zhou <Jammy.Zhou@....com>,
	xorg-driver-ati@...ts.freedesktop.org,
	LKML <linux-kernel@...r.kernel.org>,
	amd-gfx list <amd-gfx@...ts.freedesktop.org>,
	Maling list - DRI developers 
	<dri-devel@...ts.freedesktop.org>,
	Alex Deucher <alexander.deucher@....com>,
	Ken Wang <Qingqing.Wang@....com>,
	Christian König <christian.koenig@....com>
Subject: Re: [PATCH 0/7] Minor DP aux transaction fixes

On Mon, Aug 08, 2016 at 01:30:37PM -0400, Alex Deucher wrote:
> On Fri, Aug 5, 2016 at 8:30 PM, Lyude <cpaul@...hat.com> wrote:
> > While I was investigating an unrelated bug on the radeon driver, I noticed that
> > it's become rather difficult to actually read through dmesg with drm.debug
> > turned on, on account of the huge number of messages we end up printing from
> > failed DP aux transactions that happen every time we reprobe each connector.
> >
> > Timed out transactions are relatively normal, and as well there's a lot of
> > places in radeon/amdgpu where we're printing redundant debugging information
> > dozens of times each time we attempt a DP aux transactions.
> >
> > Additionally, I've removed some of the retry loops in amdgpu/radeon. These were
> > definitely useful at one point, but since we now retry any failed aux
> > transaction unconditionally in DRM's dp helpers they don't serve much purpose
> > other then to make failing aux transactions take a lot more time then they need
> > to.
> 
> I've applied the amdgpu and radeon patches.  For the drm patches, I
> can either take them through my tree or via drm-misc.

I applied the 2 core patches to drm-misc, thanks.
-Daniel

> 
> Alex
> 
> >
> > Lyude (7):
> >   drm/dp_helper: Print first error received on failure in
> >     drm_dp_dpcd_access()
> >   drm/radeon: Don't print error on aux transaction timeouts
> >   drm/radeon: Don't retry 7 times in radeon_dp_dpcd()
> >   drm/amdgpu: Don't print error on aux transaction timeouts
> >   drm/amdgpu: Don't retry 7 times in amdgpu_atombios_dp_get_dpcd()
> >   drm: Add ratelimited versions of the DRM_DEBUG* macros
> >   drm/dp_helper: Rate limit timeout errors from drm_dp_i2c_do_msg()
> >
> >  drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 22 ++++++++++------------
> >  drivers/gpu/drm/drm_dp_helper.c          | 14 ++++++++++++--
> >  drivers/gpu/drm/radeon/atombios_dp.c     | 21 ++++++++++-----------
> >  drivers/gpu/drm/radeon/radeon_dp_auxch.c |  1 -
> >  include/drm/drmP.h                       | 30 ++++++++++++++++++++++++++++++
> >  5 files changed, 62 insertions(+), 26 deletions(-)
> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@...ts.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives