linux-kernel - Re: [PATCH v3 2/2] tpm_tis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160809081439.GB10537@intel.com>
Date:	Tue, 9 Aug 2016 11:14:40 +0300
From:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:	Dmitry Torokhov <dtor@...omium.org>
Cc:	Andrey Pronin <apronin@...omium.org>,
	Peter Huewe <peterhuewe@....de>,
	Marcel Selhorst <tpmdd@...horst.net>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	Christophe Ricard <christophe.ricard@...il.com>,
	smbarber@...omium.org, dianders@...omium.org
Subject: Re: [PATCH v3 2/2] tpm_tis_spi: add max xfer size

On Thu, Jul 28, 2016 at 03:53:16PM -0700, Dmitry Torokhov wrote:
> On Wed, Jul 27, 2016 at 08:49:57PM -0700, Andrey Pronin wrote:
> > Reject burstcounts larger than 64 bytes reported by tpm.
> > SPI Hardware Protocol defined in section 6.4 of TCG PTP
> > Spec supports up to 64 bytes of data in a transaction.
> > 
> > Signed-off-by: Andrey Pronin <apronin@...omium.org>
> 
> Reviewed-by: Dmitry Torokhov <dtor@...omium.org>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>

/Jarkko

> > ---
> >  drivers/char/tpm/tpm_tis_spi.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
> > index dbaad9c..b103373 100644
> > --- a/drivers/char/tpm/tpm_tis_spi.c
> > +++ b/drivers/char/tpm/tpm_tis_spi.c
> > @@ -206,6 +206,7 @@ static const struct tpm_tis_phy_ops tpm_spi_phy_ops = {
> >  	.read16 = tpm_tis_spi_read16,
> >  	.read32 = tpm_tis_spi_read32,
> >  	.write32 = tpm_tis_spi_write32,
> > +	.max_xfer_size = MAX_SPI_FRAMESIZE,
> >  };
> >  
> >  static int tpm_tis_spi_probe(struct spi_device *dev)
> > -- 
> > 2.6.6
> > 
> 
> -- 
> Dmitry