linux-kernel - Re: [PATCH] crypto/testmgr.c: fix !x==y confusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160809110145.GD7099@gondor.apana.org.au>
Date:	Tue, 9 Aug 2016 19:01:45 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	yanjiang.jin@...driver.com
Cc:	davem@...emloft.net, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, jinyanjiang@...il.com
Subject: Re: [PATCH] crypto/testmgr.c: fix !x==y confusion

On Fri, Jul 29, 2016 at 04:32:09PM +0800, yanjiang.jin@...driver.com wrote:
> From: Yanjiang Jin <yanjiang.jin@...driver.com>
> 
> "if (!ret == template[i].fail)" is confusing to compilers (gcc5):
> 
> crypto/testmgr.c: In function '__test_aead':
> crypto/testmgr.c:531:12: warning: logical not is only applied to the
> left hand side of comparison [-Wlogical-not-parentheses]
>    if (!ret == template[i].fail) {
>             ^
> 
> Let there be 'if (template[i].fail == !ret) '.
> 
> Signed-off-by: Yanjiang Jin <yanjiang.jin@...driver.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt