linux-kernel - Re: [PATCH] i2c: don't print error when adding adapter fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5423570.keugkegXM3@diego>
Date:	Tue, 09 Aug 2016 14:13:11 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	Wolfram Sang <wsa-dev@...g-engineering.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Jean Delvare <jdelvare@...e.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	Ray Jui <rjui@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>,
	Jon Mason <jonmason@...adcom.com>,
	bcm-kernel-feedback-list@...adcom.com,
	Florian Fainelli <f.fainelli@...il.com>,
	Sonic Zhang <sonic.zhang@...log.com>,
	Brian Norris <computersforpeace@...il.com>,
	Gregory Fong <gregory.0xf0@...il.com>,
	Michal Simek <michal.simek@...inx.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Jochen Friedrich <jochen@...am.de>,
	Sekhar Nori <nsekhar@...com>,
	Kevin Hilman <khilman@...nel.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Uwe Kleine-König <kernel@...gutronix.de>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Seth Heasley <seth.heasley@...el.com>,
	Neil Horman <nhorman@...driver.com>,
	Joachim Eastwood <manabian@...il.com>,
	Carlo Caione <carlo@...one.org>,
	Alessandro Rubini <rubini@...pv.it>,
	Linus Walleij <linus.walleij@...aro.org>,
	Peter Korsgaard <jacmet@...site.dk>,
	Tony Lindgren <tony@...mide.com>,
	Vladimir Zapolskiy <vz@...ia.com>,
	Sylvain Lemieux <slemieux.tyco@...il.com>,
	Guan Xuetao <gxt@...c.pku.edu.cn>,
	Barry Song <baohua@...nel.org>,
	Patrice Chotard <patrice.chotard@...com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Tony Prisk <linux@...sktech.co.nz>,
	linux-arm-kernel@...ts.infradead.org,
	adi-buildroot-devel@...ts.sourceforge.net,
	linuxppc-dev@...ts.ozlabs.org, linux-samsung-soc@...r.kernel.org,
	linux-amlogic@...ts.infradead.org, linux-omap@...r.kernel.org,
	linux-rockchip@...ts.infradead.org, kernel@...inux.com,
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH] i2c: don't print error when adding adapter fails

Am Dienstag, 9. August 2016, 13:36:17 schrieb Wolfram Sang:
> The core will do this for us now.
> 
> Signed-off-by: Wolfram Sang <wsa-dev@...g-engineering.com>
> ---

[...]

> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 2bc8b01153d619..3b87afe82f6394 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -1303,10 +1303,8 @@ static int rk3x_i2c_probe(struct platform_device
> *pdev) rk3x_i2c_adapt_div(i2c, clk_rate);
> 
>  	ret = i2c_add_adapter(&i2c->adap);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev, "Could not register adapter\n");
> +	if (ret < 0)
>  		goto err_clk_notifier;
> -	}
> 
>  	dev_info(&pdev->dev, "Initialized RK3xxx I2C bus at %p\n", i2c->regs);

for Rockchip
Acked-by: Heiko Stuebner <heiko@...ech.de>