linux-kernel - Re: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160809121753.GZ8132@piout.net>
Date:	Tue, 9 Aug 2016 14:17:53 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code
 assignment before test

On 09/08/2016 at 14:03:35 +0200, Julia Lawall wrote :
> 
> 
> On Tue, 9 Aug 2016, Christophe JAILLET wrote:
> 
> > It is likely that checking the result of 'pcf2123_write_reg' is expected
> > here.
> > Also fix a small style issue. The '{' at the beginning of the function
> > is misplaced.
> 
> They shouldn't be in the same patch.  If you are wrong about the ret
> issue, the { should still be moved.
> 

That is true but as it is a really trivial patch, I didn't care that
much.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com