linux-kernel - Re: [PATCH 2/3] fs: befs: check flags field to validate the superblock state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf8fccd9-849a-68c5-17fa-1102cb288b50@osg.samsung.com>
Date:	Tue, 9 Aug 2016 13:40:25 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Salah Triki <salah.triki@...il.com>, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] fs: befs: check flags field to validate the
 superblock state

On 09/08/16 13:32, Salah Triki wrote:
> flags field records the superblock state, so check if it is equal to
> BEFS_DIRTY.
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  fs/befs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/befs/super.c b/fs/befs/super.c
> index 5ab75e8..79be409 100644
> --- a/fs/befs/super.c
> +++ b/fs/befs/super.c
> @@ -103,7 +103,7 @@ befs_check_sb(struct super_block *sb)
>  		return BEFS_ERR;
>  	}
>  
> -	if (befs_sb->log_start != befs_sb->log_end) {
> +	if (befs_sb->log_start != befs_sb->log_end || befs_sb->flags == BEFS_DIRTY) {
>  		befs_error(sb, "Filesystem not clean! There are blocks in the "
>  			   "journal. You must boot into BeOS and mount this volume "
>  			   "to make it clean.");
> 

Hi Salah,

Looks like a good idea. Any reason why commit 1/2, where you add the flag, and commit
2/2, where you read it, are split and not in the same commit? Curious.

Will test it soon.

Thanks :)
Luis