linux-kernel - Re: [PATCH] lockdep: fix warning in case of no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160809125314.GI30192@twins.programming.kicks-ass.net>
Date:	Tue, 9 Aug 2016 14:53:14 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] lockdep: fix warning in case of no_validate lock

On Wed, Jul 13, 2016 at 11:06:36AM +0800, Ming Lei wrote:
> Now there are several locks which are marked as
> no_validate, so name of the lock class can be
> different with the no_validate lock.

Hurgh, how did that happen? See checkpatch saying:

  scripts/checkpatch.pl: "lockdep_no_validate class is reserved for device->mutex.\n" .  $herecurr);

> This patch avoids this warning for this case, and
> fix the following warning:

I'm not sure we want that.. given we should strive for less no_validate
usage, not more.