linux-kernel - Re: [PATCH] mfd: syscon: Make use of of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160809125753.GH5243@dell>
Date:	Tue, 9 Aug 2016 13:57:53 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Andrey Smirnov <andrew.smirnov@...il.com>
Cc:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] mfd: syscon: Make use of of_iomap

On Sun, 07 Aug 2016, Andrey Smirnov wrote:

> Use of_iomap instead of explicitly calling of_address_to_resource() and
> ioremap().
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> ---
>  drivers/mfd/syscon.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index 2f2225e..55b883d 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -59,12 +59,7 @@ static struct syscon *of_syscon_register(struct device_node *np)
>  	if (!syscon)
>  		return ERR_PTR(-ENOMEM);
>  
> -	if (of_address_to_resource(np, 0, &res)) {
> -		ret = -ENOMEM;
> -		goto err_map;
> -	}
> -
> -	base = ioremap(res.start, resource_size(&res));
> +	base = of_iomap(np, 0);
>  	if (!base) {
>  		ret = -ENOMEM;
>  		goto err_map;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog