linux-kernel - Re: [RFC PATCH V5 0/5] ECAM quirks handling for ARM64 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160809102926.GT22012@rric.localdomain>
Date:	Tue, 9 Aug 2016 12:29:26 +0200
From:	Robert Richter <robert.richter@...ium.com>
To:	Tomasz Nowicki <tn@...ihalf.com>
CC:	<helgaas@...nel.org>, <arnd@...db.de>, <will.deacon@....com>,
	<catalin.marinas@....com>, <rafael@...nel.org>,
	<Lorenzo.Pieralisi@....com>, <hanjun.guo@...aro.org>,
	<okaya@...eaurora.org>, <jchandra@...adcom.com>,
	<cov@...eaurora.org>, <dhdang@....com>,
	<ard.biesheuvel@...aro.org>, <mw@...ihalf.com>,
	<Liviu.Dudau@....com>, <ddaney@...iumnetworks.com>,
	<wangyijing@...wei.com>, <msalter@...hat.com>,
	<linux-pci@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linaro-acpi@...ts.linaro.org>, <jcm@...hat.com>,
	<andrea.gallo@...aro.org>, <jeremy.linton@....com>,
	<liudongdong3@...wei.com>, <gabriele.paoloni@...wei.com>,
	<jhugo@...eaurora.org>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH V5 0/5] ECAM quirks handling for ARM64 platforms

On 08.08.16 15:05:36, Tomasz Nowicki wrote:
> Quirk handling relies on an idea of matching MCFG OEM ID, TABLE ID and
> revision (the ones from standard header of MCFG table).
> 
> Static array is used to keep quirk entries. Each entry consists of
> mentioned MCFG IDs along with custom pci_ops structure and initialization call.
> 
> As an example, the last patch presents quirk handling mechanism usage for
> ThunderX PEM driver.
> 
> v4 -> v5
> - rebase against v4.8-rc1
> - rework to exact MCFG OEM ID, TABLE ID, rev match
>   - use memcmp instead of strncmp
>   - no substring match
> - fix typos and dmesg message
> 
> Tomasz Nowicki (5):
>   PCI: Embed pci_ecam_ops in pci_config_window structure
>   PCI/ACPI: Move ACPI ECAM mapping to generic MCFG driver
>   PCI: Check platform specific ECAM quirks
>   ARM64/PCI: Start using quirks handling for ACPI based PCI host
>     controller
>   PCI: thunder-pem: Support quirky configuration space access for ACPI
>     based PCI host controller
> 
>  arch/arm64/kernel/pci.c            | 42 +----------------
>  drivers/acpi/pci_mcfg.c            | 40 ++++++++++++++++
>  drivers/pci/ecam.c                 |  6 +--
>  drivers/pci/host/Makefile          |  1 +
>  drivers/pci/host/mcfg-quirks.c     | 93 ++++++++++++++++++++++++++++++++++++
>  drivers/pci/host/mcfg-quirks.h     | 24 ++++++++++
>  drivers/pci/host/pci-thunder-pem.c | 96 ++++++++++++++++++++++++++++++++------
>  include/linux/pci-acpi.h           |  5 ++
>  include/linux/pci-ecam.h           |  2 +-
>  9 files changed, 252 insertions(+), 57 deletions(-)
>  create mode 100644 drivers/pci/host/mcfg-quirks.c
>  create mode 100644 drivers/pci/host/mcfg-quirks.h

For the whole series

Reviewed-by: Robert Richter <rrichter@...ium.com>
Tested-by: Robert Richter <rrichter@...ium.com>

Test included:

 [PATCH V7 0/8] Introduce ACPI world to ITS irqchip

Thanks Tomasz,

-Robert