linux-kernel - Re: [PATCH V2] usb: ehci-platform: use helper variables in probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 15:59:28 +0200
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	Tony Prisk <linux@...sktech.co.nz>,
	Alan Stern <stern@...land.harvard.edu>,
	"moderated list:ARM/VT8500 ARM ARCHITECTURE" 
	<linux-arm-kernel@...ts.infradead.org>,
	"open list:USB EHCI DRIVER" <linux-usb@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] usb: ehci-platform: use helper variables in probe
 function

On Fri, Jul 15, 2016 at 07:05:56AM +0200, Rafał Miłecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
> 
> Signed-off-by: Rafał Miłecki <zajec5@...il.com>
> Acked-by: Alan Stern <stern@...land.harvard.edu>
> ---
> V2: Use 2 extra tabs after line break to match one of already used
>     coding styles.

Same comment here, unnecessary churn, sorry.

greg k-h