linux-kernel - Re: [PATCH 08/20] usb: host: ehci-sead3: Remove non-DT probe code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1608091020260.1919-100000@iolanthe.rowland.org>
Date:	Tue, 9 Aug 2016 10:21:04 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Paul Burton <paul.burton@...tec.com>
cc:	linux-mips@...ux-mips.org, Ralf Baechle <ralf@...ux-mips.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 08/20] usb: host: ehci-sead3: Remove non-DT probe code

On Tue, 9 Aug 2016, Paul Burton wrote:

> Now that the SEAD3 board is probing the EHCI controller using device
> tree, remove the non-DT support from the probe function.
> 
> Signed-off-by: Paul Burton <paul.burton@...tec.com>
> ---
> 
>  drivers/usb/host/ehci-sead3.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-sead3.c b/drivers/usb/host/ehci-sead3.c
> index 05db1ae..b88ecfe 100644
> --- a/drivers/usb/host/ehci-sead3.c
> +++ b/drivers/usb/host/ehci-sead3.c
> @@ -102,18 +102,10 @@ static int ehci_hcd_sead3_drv_probe(struct platform_device *pdev)
>  	if (usb_disabled())
>  		return -ENODEV;
>  
> -	if (pdev->dev.of_node) {
> -		irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
> -		if (!irq) {
> -			dev_err(&pdev->dev, "failed to map IRQ\n");
> -			return -ENODEV;
> -		}
> -	} else {
> -		if (pdev->resource[1].flags != IORESOURCE_IRQ) {
> -			pr_debug("resource[1] is not IORESOURCE_IRQ");
> -			return -ENOMEM;
> -		}
> -		irq = pdev->resource[1].start;
> +	irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
> +	if (!irq) {
> +		dev_err(&pdev->dev, "failed to map IRQ\n");
> +		return -ENODEV;
>  	}
>  
>  	hcd = usb_create_hcd(&ehci_sead3_hc_driver, &pdev->dev, "SEAD-3");

For both this patch and the 06/20 patch:

Acked-by: Alan Stern <stern@...land.harvard.edu>