linux-kernel - RE: [PATCH] megaraid_sas: Fix probing cards without io port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <240effe70dbbcd5803e70163aacbe57a@mail.gmail.com>
Date:	Tue, 9 Aug 2016 23:22:12 +0530
From:	Kashyap Desai <kashyap.desai@...adcom.com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Yinghai Lu <yinghai@...nel.org>
Cc:	Kashyap Desai <kashyap.desai@...gotech.com>,
	Sumit Saxena <sumit.saxena@...gotech.com>,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	megaraidlinux.pdl@...gotech.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: RE: [PATCH] megaraid_sas: Fix probing cards without io port

 > > that does not io port resource allocated from BIOS, and kernel can
not
> > assign one as io port shortage.
> >
> > The driver is only looking for MEM, and should not fail.
>
> > It turns out megasas_init_fw() etc are using bar index as mask.
> > index 1 is used as mask 1, so that pci_request_selected_regions() is
> > trying to request BAR0 instead of BAR1.
>
> > Fix all related reference.

Review patch and looks good. Thanks Yinghai for submitting patch.

Acked-by:  Kashyap Desai <kashyap.desai@...adcom.com>

>
> Kashyap? Sumit?
>
> --
> Martin K. Petersen	Oracle Linux Engineering