linux-kernel - Re: [PACTH v1] mm, proc: Implement /proc/<pid>/totmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPz6YkXatPNsoun52gMd3cJcpVDgiUN4qpie1Gs23nN53Bzk3Q@mail.gmail.com>
Date:	Tue, 9 Aug 2016 11:28:36 -0700
From:	Sonny Rao <sonnyrao@...omium.org>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Robert Foss <robert.foss@...labora.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kees Cook <keescook@...omium.org>, viro@...iv.linux.org.uk,
	gorcunov@...nvz.org, John Stultz <john.stultz@...aro.org>,
	Robin Humble <plaguedbypenguins@...il.com>,
	Mateusz Guzik <mguzik@...hat.com>,
	Janis Danisevskis <jdanis@...gle.com>, calvinowens@...com,
	jann@...jh.net, mhocko@...e.com,
	Konstantin Khlebnikov <koct9i@...il.com>, vbabka@...e.cz,
	n-horiguchi@...jp.nec.com, kirill.shutemov@...ux.intel.com,
	ldufour@...ux.vnet.ibm.com, Johannes Weiner <hannes@...xchg.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ben Zhang <benzh@...omium.org>,
	Filipe Brandenburger <filbranden@...omium.org>
Subject: Re: [PACTH v1] mm, proc: Implement /proc/<pid>/totmaps

On Tue, Aug 9, 2016 at 9:58 AM, Alexey Dobriyan <adobriyan@...il.com> wrote:
>
> On Tue, Aug 09, 2016 at 12:05:43PM -0400, robert.foss@...labora.com wrote:
> > From: Sonny Rao <sonnyrao@...omium.org>
> >
> > This is based on earlier work by Thiago Goncales. It implements a new
> > per process proc file which summarizes the contents of the smaps file
> > but doesn't display any addresses.  It gives more detailed information
> > than statm like the PSS (proprotional set size).  It differs from the
> > original implementation in that it doesn't use the full blown set of
> > seq operations, uses a different termination condition, and doesn't
> > displayed "Locked" as that was broken on the original implemenation.
> >
> > This new proc file provides information faster than parsing the potentially
> > huge smaps file.
>
> You can "parse" /proc/*/pagemap . RSS, swap are there.


/proc/*pagemap is generally restricted and I don't believe it would
quickly give PSS.

>
> So which ones do you really need?

PSS and Swap are the most important.  RSS isn't precise enough because
it counts shared pages fully, and there tends to be a lot of sharing.

> Why the separate anon hugepages and anon regular pages?

I'm not sure if it's necessary, but that's how it's broken out in smaps.

>
> > +     seq_printf(m,
> > +                "Rss:            %8lu kB\n"
> > +                "Pss:            %8lu kB\n"
> > +                "Shared_Clean:   %8lu kB\n"
> > +                "Shared_Dirty:   %8lu kB\n"
> > +                "Private_Clean:  %8lu kB\n"
> > +                "Private_Dirty:  %8lu kB\n"
> > +                "Referenced:     %8lu kB\n"
> > +                "Anonymous:      %8lu kB\n"
> > +                "AnonHugePages:  %8lu kB\n"
> > +                "Swap:           %8lu kB\n",
> > +                mss_sum->resident >> 10,
> > +                (unsigned long)(mss_sum->pss >> (10 + PSS_SHIFT)),
> > +                mss_sum->shared_clean  >> 10,
> > +                mss_sum->shared_dirty  >> 10,
> > +                mss_sum->private_clean >> 10,
> > +                mss_sum->private_dirty >> 10,
> > +                mss_sum->referenced >> 10,
> > +                mss_sum->anonymous >> 10,
> > +                mss_sum->anonymous_thp >> 10,
> > +                mss_sum->swap >> 10);