linux-kernel - Re: [PATCH] x86/mm: minor warning message cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 20:40:38 +0200
From:	Borislav Petkov <bp@...e.de>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Andy Lutomirski <luto@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH] x86/mm: minor warning message cleanup

On Tue, Aug 09, 2016 at 01:56:31PM -0400, Prarit Bhargava wrote:
> Capitalize R in RIP.
> 
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: x86@...nel.org
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Borislav Petkov <bp@...e.de>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Cc: Tony Luck <tony.luck@...el.com>
> ---
>  arch/x86/mm/extable.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c
> index 832b98f822be..bef3aa199f94 100644
> --- a/arch/x86/mm/extable.c
> +++ b/arch/x86/mm/extable.c
> @@ -62,7 +62,7 @@ EXPORT_SYMBOL(ex_handler_rdmsr_unsafe);
>  bool ex_handler_wrmsr_unsafe(const struct exception_table_entry *fixup,
>  			     struct pt_regs *regs, int trapnr)
>  {
> -	if (pr_warn_once("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at rIP: 0x%lx (%pF)\n",
> +	if (pr_warn_once("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at RIP: 0x%lx (%pF)\n",

Nope:

rIP:	16-bit, 32-bit, or 64-bit instruction-pointer register. Compare RIP.
RIP:	64-bit instruction-pointer register.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--