linux-kernel - Re: [PATCH v5 5/5] lib/dlock-list: Make sibling CPUs share the same linked list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 15:46:38 -0400
From:	Waiman Long <waiman.long@....com>
To:	kbuild test robot <lkp@...el.com>
CC:	<kbuild-all@...org>, Alexander Viro <viro@...iv.linux.org.uk>,
	Jan Kara <jack@...e.com>,
	Jeff Layton <jlayton@...chiereds.net>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Tejun Heo <tj@...nel.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Andi Kleen <andi@...stfloor.org>,
	Dave Chinner <dchinner@...hat.com>,
	Boqun Feng <boqun.feng@...il.com>,
	Scott J Norton <scott.norton@....com>,
	Douglas Hatch <doug.hatch@....com>
Subject: Re: [PATCH v5 5/5] lib/dlock-list: Make sibling CPUs share the same
 linked list

On 08/09/2016 02:23 PM, kbuild test robot wrote:
> Hi Waiman,
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.8-rc1 next-20160809]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Waiman-Long/vfs-Use-dlock-list-for-SB-s-s_inodes-list/20160810-012457
> config: i386-randconfig-s0-201632 (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>          # save the attached .config to linux build tree
>          make ARCH=i386
>
> All error/warnings (new ones prefixed by>>):
>
>     lib/dlock-list.c: In function 'cpu2list_init':
>>> lib/dlock-list.c:60:15: error: assignment to expression with array type
>       sibling_mask = topology_sibling_cpumask(0);
>                    ^
>>> lib/dlock-list.c:61:6: warning: the address of 'sibling_mask' will always evaluate as 'true' [-Waddress]
>       if (!sibling_mask)
>           ^
>     lib/dlock-list.c:74:16: error: assignment to expression with array type
>        sibling_mask = topology_sibling_cpumask(cpu);
>                     ^
>
> vim +60 lib/dlock-list.c
>
>      54		cpumask_var_t sibling_mask;
>      55		static struct cpumask mask __initdata;
>      56	
>      57		/*
>      58		 * Check # of sibling CPUs for CPU 0
>      59		 */
>    >  60		sibling_mask = topology_sibling_cpumask(0);
>    >  61		if (!sibling_mask)
>      62			goto done;
>      63		nr_siblings = cpumask_weight(sibling_mask);
>      64		if (nr_siblings == 1)
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

I have updated and re-sent patch 5 that should fix the non-SMP build error.

Cheers,
Longman