linux-kernel - Re: [PATCH resend v3 3/5] libata-scsi: use u8 array to store mode page copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 16:13:49 -0400
From:	Tejun Heo <tj@...nel.org>
To:	tom.ty89@...il.com
Cc:	hare@...e.de, sergei.shtylyov@...entembedded.com, arnd@...db.de,
	sfr@...b.auug.org.au, linux-ide@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org
Subject: Re: [PATCH resend v3 3/5] libata-scsi: use u8 array to store mode
 page copy

On Sat, Jul 23, 2016 at 02:34:08AM +0800, tom.ty89@...il.com wrote:
> From: Tom Yan <tom.ty89@...il.com>
> 
> ata_mselect_*() would initialize a char array for storing a copy of
> the current mode page. However, char could be signed char. In that
> case, bytes larger than 127 would be converted to negative number.
> 
> For example, 0xff from def_control_mpage[] would become -1. This
> prevented ata_mselect_control() from working at all, since when it
> did the read-only bits check, there would always be a mismatch.
> 
> Signed-off-by: Tom Yan <tom.ty89@...il.com>

Applied to libata/for-4.9.

Thanks.

-- 
tejun