linux-kernel - [PATCH] staging/rtl8188eu/core/rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1470720897.23538.2.camel@oracle.com>
Date:	Tue, 09 Aug 2016 01:34:57 -0400
From:	Lidza Louina <lidza.louina@...cle.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ivan Safonov <insafonov@...il.com>,
	Kyle Kuffermann <kyle.kuffermann@...il.com>,
	Sandhya Bankar <bankarsandhya512@...il.com>,
	Geliang Tang <geliangtang@....com>,
	Bryan Paul <bryan.paul@...oo.com>,
	Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging/rtl8188eu/core/rtw_cmd: Fixes semaphore locking

The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
The code had an up() where a down() should've been. This patch fixes that.

Signed-off-by: Lidza Louina <Lidza.Louina@...cle.com>
---
 drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 7748523..16f0b19 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
@@ -162,7 +162,7 @@ int rtw_cmd_thread(void *context)
 	allow_signal(SIGTERM);
 
 	pcmdpriv->cmdthd_running = true;
-	up(&pcmdpriv->terminate_cmdthread_sema);
+	down(&pcmdpriv->terminate_cmdthread_sema);
 
 	RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_, ("start r871x rtw_cmd_thread !!!!\n"));
 
-- 
2.7.4