linux-kernel - Re: [PATCH] i2c: don't print error when adding adapter fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160810061715.GH12809@odux.rfo.atmel.com>
Date:	Wed, 10 Aug 2016 08:17:15 +0200
From:	Ludovic Desroches <ludovic.desroches@...el.com>
To:	Wolfram Sang <wsa-dev@...g-engineering.com>
CC:	<linux-kernel@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
	Jean Delvare <jdelvare@...e.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	Ray Jui <rjui@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>,
	Jon Mason <jonmason@...adcom.com>,
	<bcm-kernel-feedback-list@...adcom.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Sonic Zhang <sonic.zhang@...log.com>,
	Brian Norris <computersforpeace@...il.com>,
	Gregory Fong <gregory.0xf0@...il.com>,
	"Michal Simek" <michal.simek@...inx.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Jochen Friedrich <jochen@...am.de>,
	Sekhar Nori <nsekhar@...com>,
	Kevin Hilman <khilman@...nel.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Uwe Kleine-König <kernel@...gutronix.de>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Seth Heasley <seth.heasley@...el.com>,
	Neil Horman <nhorman@...driver.com>,
	Joachim Eastwood <manabian@...il.com>,
	Carlo Caione <carlo@...one.org>,
	Alessandro Rubini <rubini@...pv.it>,
	Linus Walleij <linus.walleij@...aro.org>,
	Peter Korsgaard <jacmet@...site.dk>,
	"Tony Lindgren" <tony@...mide.com>,
	Vladimir Zapolskiy <vz@...ia.com>,
	"Sylvain Lemieux" <slemieux.tyco@...il.com>,
	Guan Xuetao <gxt@...c.pku.edu.cn>,
	"Heiko Stuebner" <heiko@...ech.de>, Barry Song <baohua@...nel.org>,
	Patrice Chotard <patrice.chotard@...com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	"Thierry Reding" <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Tony Prisk <linux@...sktech.co.nz>,
	<linux-arm-kernel@...ts.infradead.org>,
	<adi-buildroot-devel@...ts.sourceforge.net>,
	<linuxppc-dev@...ts.ozlabs.org>,
	<linux-samsung-soc@...r.kernel.org>,
	<linux-amlogic@...ts.infradead.org>, <linux-omap@...r.kernel.org>,
	<linux-rockchip@...ts.infradead.org>, <kernel@...inux.com>,
	<linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] i2c: don't print error when adding adapter fails

On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote:
> The core will do this for us now.
> 
> Signed-off-by: Wolfram Sang <wsa-dev@...g-engineering.com>
> ---

[...]

>  drivers/i2c/busses/i2c-at91.c           | 2 --

Acked-by: Ludovic Desroches <ludovic.desroches@...el.com>

[...]

> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index f23372669f770f..03a519d29616d7 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
> @@ -1118,8 +1118,6 @@ static int at91_twi_probe(struct platform_device *pdev)
>  
>  	rc = i2c_add_numbered_adapter(&dev->adapter);
>  	if (rc) {
> -		dev_err(dev->dev, "Adapter %s registration failed\n",
> -			dev->adapter.name);
>  		clk_disable_unprepare(dev->clk);
>  
>  		pm_runtime_disable(dev->dev);