linux-kernel - [tip:x86/urgent] x86/platform/UV: Fix kernel panic running RHEL kdump kernel on UV systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-5a52e8f822374bebc702bb2688ed8b5515bbb55b@git.kernel.org>
Date:	Wed, 10 Aug 2016 11:12:31 -0700
From:	tip-bot for Mike Travis <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	sivanich@....com, travis@....com, abanman@....com,
	estabrook@....com, torvalds@...ux-foundation.org,
	tglx@...utronix.de, peterz@...radead.org,
	akpm@...ux-foundation.org, framsay@....com, rja@....com,
	hpa@...or.com, athorlton@....com, linux-kernel@...r.kernel.org,
	mingo@...nel.org, nzimmer@....com
Subject: [tip:x86/urgent] x86/platform/UV: Fix kernel panic running RHEL
 kdump kernel on UV systems

Commit-ID:  5a52e8f822374bebc702bb2688ed8b5515bbb55b
Gitweb:     http://git.kernel.org/tip/5a52e8f822374bebc702bb2688ed8b5515bbb55b
Author:     Mike Travis <travis@....com>
AuthorDate: Mon, 1 Aug 2016 13:40:53 -0500
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 10 Aug 2016 15:55:39 +0200

x86/platform/UV: Fix kernel panic running RHEL kdump kernel on UV systems

The latest UV kernel support panics when RHEL7 kexec's the kdump kernel
to make a dumpfile.  This patch fixes the problem by turning off all UV
support if NUMA is off.

Tested-by: Frank Ramsay <framsay@....com>
Tested-by: John Estabrook <estabrook@....com>
Signed-off-by: Mike Travis <travis@....com>
Reviewed-by: Dimitri Sivanich <sivanich@....com>
Reviewed-by: Nathan Zimmer <nzimmer@....com>
Cc: Alex Thorlton <athorlton@....com>
Cc: Andrew Banman <abanman@....com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Russ Anderson <rja@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Link: http://lkml.kernel.org/r/20160801184050.577755634@asylum.americas.sgi.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/kernel/apic/x2apic_uv_x.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c b/arch/x86/kernel/apic/x2apic_uv_x.c
index 6aa0545..cb0673c 100644
--- a/arch/x86/kernel/apic/x2apic_uv_x.c
+++ b/arch/x86/kernel/apic/x2apic_uv_x.c
@@ -223,6 +223,11 @@ static int __init uv_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
 	if (strncmp(oem_id, "SGI", 3) != 0)
 		return 0;
 
+	if (numa_off) {
+		pr_err("UV: NUMA is off, disabling UV support\n");
+		return 0;
+	}
+
 	/* Setup early hub type field in uv_hub_info for Node 0 */
 	uv_cpu_info->p_uv_hub_info = &uv_hub_info_node0;