linux-kernel - Re: [PATCH 4/5] gpu: drm: radeon: radeon_i2c: don't print error when adding adapter fails

Open Source and information security mailing list archives

Message-ID: <CADnq5_OYiBmpwJBz3CscnxcR8dC0UNmz+5OCXM-aFFFb5PV5zQ@mail.gmail.com>
Date:	Wed, 10 Aug 2016 14:10:30 -0400
From:	Alex Deucher <alexdeucher@...il.com>
To:	Wolfram Sang <wsa-dev@...g-engineering.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Maling list - DRI developers 
	<dri-devel@...ts.freedesktop.org>,
	Linux I2C <linux-i2c@...r.kernel.org>,
	Alex Deucher <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>
Subject: Re: [PATCH 4/5] gpu: drm: radeon: radeon_i2c: don't print error when
 adding adapter fails

On Tue, Aug 9, 2016 at 7:30 AM, Wolfram Sang
<wsa-dev@...g-engineering.com> wrote:
> The core will do this for us now.
>
> Signed-off-by: Wolfram Sang <wsa-dev@...g-engineering.com>

Applied patches 1, 5.

Thanks,

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_i2c.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
> index 9590bcd321c09a..021aa005623f80 100644
> --- a/drivers/gpu/drm/radeon/radeon_i2c.c
> +++ b/drivers/gpu/drm/radeon/radeon_i2c.c
> @@ -938,10 +938,8 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
>                          "Radeon i2c hw bus %s", name);
>                 i2c->adapter.algo = &radeon_i2c_algo;
>                 ret = i2c_add_adapter(&i2c->adapter);
> -               if (ret) {
> -                       DRM_ERROR("Failed to register hw i2c %s\n", name);
> +               if (ret)
>                         goto out_free;
> -               }
>         } else if (rec->hw_capable &&
>                    radeon_hw_i2c &&
>                    ASIC_IS_DCE3(rdev)) {
> @@ -950,10 +948,8 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
>                          "Radeon i2c hw bus %s", name);
>                 i2c->adapter.algo = &radeon_atom_i2c_algo;
>                 ret = i2c_add_adapter(&i2c->adapter);
> -               if (ret) {
> -                       DRM_ERROR("Failed to register hw i2c %s\n", name);
> +               if (ret)
>                         goto out_free;
> -               }
>         } else {
>                 /* set the radeon bit adapter */
>                 snprintf(i2c->adapter.name, sizeof(i2c->adapter.name),
> --
> 2.8.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives