linux-kernel - Re: [PATCH 2/2] device-tree: nexus7: Add IMEM syscon and reboot reason support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLWWDQVyMVEP5kB2h0ig0WuX8Vq8TmO_Gd+Yaesa1k3qwA@mail.gmail.com>
Date:	Tue, 9 Aug 2016 22:04:00 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Andy Gross <agross@...eaurora.org>,
	Stephen Boyd <stephen.boyd@...aro.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] device-tree: nexus7: Add IMEM syscon and reboot
 reason support

On Tue, Aug 9, 2016 at 9:28 PM, Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
> On Mon 08 Aug 15:34 PDT 2016, John Stultz wrote:
>
>> This patch add the IMEM syscon memory region to the DT,
>> as well as addds support for the magic reboot reason
>> values that are written to the address for each mode.
>>
>
> This looks good, double checked the addresses and magics. But I think
> you should move the entire thing to qcom-apq8064.dtsi, as this is common
> to the base platform.

Interesting, so do all 8064's use the same bootloader?

> And I would prefer if you updated the subject prefix...
>
> With the move and subject update:
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

thanks!
-john