linux-kernel - Re: [PATCH v2] x86/hweight: fix open-coded versions of 32bit and 64bit hweight calculations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1608101604370.22028@cbobk.fhfr.pm>
Date:	Wed, 10 Aug 2016 16:05:58 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Ingo Molnar <mingo@...nel.org>
cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	Mike Galbraith <umgwanakikbuti@...il.com>,
	Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH v2] x86/hweight: fix open-coded versions of 32bit and
 64bit hweight calculations

On Wed, 10 Aug 2016, Ingo Molnar wrote:

> >  ENTRY(__sw_hweight64)
> > -#ifdef CONFIG_X86_64
> > +
> 
> So this removes an #ifdef without removing the #else branch.

Hi Ingo,

this patch is obsolete; the real issue has already been fixed by 65ea11ec6 
("x86/hweight: Don't clobber %rdi") in Linus' tree already.

Thanks,

-- 
Jiri Kosina
SUSE Labs