linux-kernel - Re: [PATCH] omapfb: omapfb-main: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7085eecc-dbeb-0e0f-dc95-c33f2f72d5b0@ti.com>
Date:	Wed, 10 Aug 2016 13:50:05 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Tejun Heo <tj@...nel.org>,
	Bhaktipriya Shridhar <bhaktipriya96@...il.com>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	<linux-omap@...r.kernel.org>, <linux-fbdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] omapfb: omapfb-main: Remove deprecated
 create_singlethread_workqueue


On 02/07/16 14:34, Tejun Heo wrote:
> On Sat, Jul 02, 2016 at 02:00:56PM +0530, Bhaktipriya Shridhar wrote:
>> The workqueue auto_update_work is involved in auto updating mode for
>> manual-update displays. omapfb driver uses a delayed work item to update
>> the display at a constant rate.
>>
>> Since these long-running work items aren't involved in memory reclaim in
>> any way, system_long_wq has been used.
> 
> Can you please explain why this is long-running?

It shouldn't be long-running. update() should only start the transfer to
the display.

Although if something is not right (the user sets the auto-update
frequency to too high), the work could end up waiting for the previous
update to finish...

It's a debugging feature, so maybe that's not an issue.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)