linux-kernel - Re: [PATCH] get_maintainer: Don't check if STDIN exists in a VCS repository

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ea1a8e5-c472-4e5e-d177-03c12e282475@codeaurora.org>
Date:	Wed, 10 Aug 2016 14:38:56 -0400
From:	Christopher Covington <cov@...eaurora.org>
To:	Joe Perches <joe@...ches.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] get_maintainer: Don't check if STDIN exists in a VCS
 repository

On 08/10/2016 11:45 AM, Joe Perches wrote:
> If get_maintainer is not given any filename arguments on the command line,
> the standard input is read for a patch.
> 
> But checking if a VCS has a file named &STDIN is not a good idea and fails.
> 
> Verify the nominal input file is not &STDIN before checking the VCS.
> 
> Fixes: 4cad35a7ca69 ("get_maintainer.pl: reduce need for command-line option -f")
> Reported-by: Christopher Covington <cov@...eaurora.org>
> Signed-off-by: Joe Perches <joe@...ches.com>

Thanks Joe, that fixes it!

Tested-by: Christopher Covington <cov@...eaurora.org>

> ---
>  scripts/get_maintainer.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 122fcda..49a00d5 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -432,7 +432,7 @@ foreach my $file (@ARGV) {
>  	    die "$P: file '${file}' not found\n";
>  	}
>      }
> -    if ($from_filename || vcs_file_exists($file)) {
> +    if ($from_filename || ($file ne "&STDIN" && vcs_file_exists($file))) {
>  	$file =~ s/^\Q${cur_path}\E//;	#strip any absolute path
>  	$file =~ s/^\Q${lk_path}\E//;	#or the path to the lk tree
>  	push(@files, $file);
> 


-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code
Aurora Forum, a Linux Foundation Collaborative Project.