linux-kernel - Re: [PATCH V3 2/4] clk: Combine DT binding doc for max77686 and max77802

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqL+sZ1tX_Wnj=N+ku4Gs0dNRhKDe4vDkEitAu+M4HEBmA@mail.gmail.com>
Date:	Wed, 10 Aug 2016 07:43:04 -0500
From:	Rob Herring <robh@...nel.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-clk <linux-clk@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Javier Martinez Canillas <javier@...hile0.org>
Subject: Re: [PATCH V3 2/4] clk: Combine DT binding doc for max77686 and max77802

On Wed, Aug 10, 2016 at 4:40 AM, Laxman Dewangan <ldewangan@...dia.com> wrote:
> Hi,
>
> On Tuesday 28 June 2016 04:58 PM, Laxman Dewangan wrote:
>>
>> Hi Rob,
>>
>> On Tuesday 21 June 2016 12:16 PM, Laxman Dewangan wrote:
>>>
>>>
>>> On Monday 20 June 2016 10:09 PM, Rob Herring wrote:
>>>>
>>>> On Fri, Jun 17, 2016 at 04:21:05PM +0530, Laxman Dewangan wrote:
>>>>>
>>>>>
>>>>>
>>>>> +
>>>>>   Following properties should be presend in main device node of the MFD
>>>>> chip.
>>>>>     Required properties:
>>>>
>>>> I'd expect to see compatible strings updated...
>>>>
>>>
>>> There is no separate compatible string for clock. The clock nodes is the
>>> parent node only and the compatible described in the parent DT binding doc.
>>>
>>>
>>> Do we also need to add same thing here?
>>
>>
>> Are you fine with the above? As there is no compatible string for clock
>> (clock does not have separate node), do I still need to add explicitly here?
>>
>
>
> Can you please help here to review? If required, I can rebase and re-send
> the patches.

It is fine.

Acked-by: Rob Herring <robh@...nel.org>