linux-kernel - Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFw5DczMkEYP47h=-9f6U2V5aQUhSxqPjtTbNp1Dd=gZwQ@mail.gmail.com>
Date:	Wed, 10 Aug 2016 11:56:15 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Josef Bacik <jbacik@...com>
Cc:	kernel test robot <xiaolong.ye@...el.com>,
	Al Viro <viro@...iv.linux.org.uk>, Chris Mason <clm@...com>,
	David Sterba <dsterba@...e.com>,
	"J. Bruce Fields" <bfields@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, LKP <lkp@...org>,
	linux-btrfs <linux-btrfs@...r.kernel.org>,
	Linux NFS Mailing List <linux-nfs@...r.kernel.org>
Subject: Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a}
 still in use (1) [unmount of btrfs vda]

On Wed, Aug 10, 2016 at 11:46 AM, Josef Bacik <jbacik@...com> wrote:
>
> So my naive fix would be something like this

Bruce? Josef's patch looks ObviouslyCorrect(tm) to me now that I look
at it - all the other callers of fh_compose() also seem to just drop
the dentry unconditionally, knowing that fh_compose() took a ref to it
if needed.

In fact, the only thing I'd do differently would be to not even put
the comment there at all, since this call site isn't any different
from any of the others. If anything, it could go on fh_compose() if we
want to add comments.

             Linus