linux-kernel - Re: [PATCH] fb: adv7393: Use IS_ENABLED() instead of checking for built-in or module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2380927-a419-414f-c5ec-2aabed677238@ti.com>
Date:	Wed, 10 Aug 2016 13:55:31 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Javier Martinez Canillas <javier@....samsung.com>,
	<linux-kernel@...r.kernel.org>
CC:	<linux-fbdev@...r.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
Subject: Re: [PATCH] fb: adv7393: Use IS_ENABLED() instead of checking for
 built-in or module

On 11/07/16 23:44, Javier Martinez Canillas wrote:
> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
> built-in or as a module, use that macro instead of open coding the same.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> ---
> 
>  drivers/video/fbdev/bfin_adv7393fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/bfin_adv7393fb.c b/drivers/video/fbdev/bfin_adv7393fb.c
> index 8fe41caac38e..9a01cd7ca73c 100644
> --- a/drivers/video/fbdev/bfin_adv7393fb.c
> +++ b/drivers/video/fbdev/bfin_adv7393fb.c
> @@ -795,7 +795,7 @@ static struct i2c_driver bfin_adv7393_fb_driver = {
>  
>  static int __init bfin_adv7393_fb_driver_init(void)
>  {
> -#if  defined(CONFIG_I2C_BLACKFIN_TWI) || defined(CONFIG_I2C_BLACKFIN_TWI_MODULE)
> +#if IS_ENABLED(CONFIG_I2C_BLACKFIN_TWI)
>  	request_module("i2c-bfin-twi");
>  #else
>  	request_module("i2c-gpio");
> 

Thanks, queued for v4.9.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)