linux-kernel - Re: [PATCH v2 1/4] perf/core: check return value of perf_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160810110437.GB14283@gmail.com>
Date:	Wed, 10 Aug 2016 13:04:38 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	David Carrillo-Cisneros <davidcc@...gle.com>
Cc:	linux-kernel@...r.kernel.org, "x86@...nel.org" <x86@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andi Kleen <ak@...ux.intel.com>,
	Kan Liang <kan.liang@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Paul Turner <pjt@...gle.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v2 1/4] perf/core: check return value of perf_event_read
 IPI


* David Carrillo-Cisneros <davidcc@...gle.com> wrote:

> The call to smp_call_function_single in perf_event_read() may fail and,
> when it does, its error value is the one to return.
> 
> Signed-off-by: David Carrillo-Cisneros <davidcc@...gle.com>
> Reviewed-by: Stephane Eranian <eranian@...gle.com>
> ---
>  kernel/events/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 9345028..96523fd 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -3469,9 +3469,9 @@ static int perf_event_read(struct perf_event *event, bool group)
>  			.group = group,
>  			.ret = 0,
>  		};
> -		smp_call_function_single(event->oncpu,
> -					 __perf_event_read, &data, 1);
> -		ret = data.ret;
> +		ret = smp_call_function_single(event->oncpu,
> +					       __perf_event_read, &data, 1);
> +		ret = ret ? : data.ret;
>  	} else if (event->state == PERF_EVENT_STATE_INACTIVE) {
>  		struct perf_event_context *ctx = event->ctx;
>  		unsigned long flags;

Please also describe the symptoms of the bug - under what circumstances may the 
smp-call fail and how does the user notice?

Thanks,

        Ingo