linux-kernel - Re: [PATCH 0244/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZsgSfL9rwe-vU5S6nNy0weD3O3PZymUZQsvJhQTSjf=w@mail.gmail.com>
Date:	Wed, 10 Aug 2016 15:02:05 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	Guenter Roeck <linux@...ck-us.net>,
	Dave Airlie <airlied@...ux.ie>, Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozłowski <k.kozlowski@...sung.com>,
	dougthompson@...ssion.com, Borislav Petkov <bp@...en8.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	chuansheng.liu@...el.com, Andrew Duggan <aduggan@...aptics.com>,
	Doug Anderson <dianders@...omium.org>
Subject: Re: [PATCH 0244/1285] Replace numeric parameter like 0444 with macro

On Tue, Aug 2, 2016 at 12:52 PM, Baole Ni <baolex.ni@...el.com> wrote:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

I assume Wolfram will merge this.

Yours,
Linus Walleij