linux-kernel - RE: [PATCH 3/4] Drivers: hv: balloon: get rid on ol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN3PR03MB21464E3B83458F6A08DC8861D81D0@BN3PR03MB2146.namprd03.prod.outlook.com>
Date:	Wed, 10 Aug 2016 18:12:05 +0000
From:	"Alex Ng (LIS)" <alexng@...rosoft.com>
To:	Vitaly Kuznetsov <vkuznets@...hat.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Haiyang Zhang" <haiyangz@...rosoft.com>,
	KY Srinivasan <kys@...rosoft.com>
Subject: RE: [PATCH 3/4] Drivers: hv: balloon: get rid on ol_waitevent

> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
> Sent: Friday, August 5, 2016 3:49 AM
> To: devel@...uxdriverproject.org
> Cc: linux-kernel@...r.kernel.org; Haiyang Zhang <haiyangz@...rosoft.com>; KY
> Srinivasan <kys@...rosoft.com>; Alex Ng (LIS) <alexng@...rosoft.com>
> Subject: [PATCH 3/4] Drivers: hv: balloon: get rid on ol_waitevent
> 
> With the recently introduced in-kernel memory onlining
> (MEMORY_HOTPLUG_DEFAULT_ONLINE) these it no point in waiting for pages
> to come online in the driver and in case the feature is disabled the 5
> second wait won't help. Get rid of the waiting.
> 

Continuing our internal discussion here. Here's the context.

> > Is it necessary to remove the ol_waitevent in "Drivers: hv: balloon: get rid
> > on ol_waitevent"? If we respond to the host too quickly, then the next
> > hot-add request may not see the new pages come online and could fail to
> > alloc memory as seen in the call trace.
> > 
> > Thoughts?
> 
> This should not be an issue with CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE: we
> online pages when we add them (add_memory()) so when we reply to the host
> these pages are already online. But in case the onlining is done by an
> external tool (e.g. udev) this wait helps (not always, as if someone eats
> all memory before the next add_memory call we're still in trouble).

MEMORY_HOTPLUG_DEFAULT_ONLINE is disabled in Kconfig by default. 
Would it make sense to keep the wait and only #ifdef it out when CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE is set?