linux-kernel - Re: [PATCH 1/2] device-tree: aqp8064.dtsi: Remove usb phy dr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160810040937.GF26240@tuxbot>
Date:	Tue, 9 Aug 2016 21:09:37 -0700
From:	Bjorn Andersson <bjorn.andersson@...aro.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Andy Gross <agross@...eaurora.org>,
	Stephen Boyd <stephen.boyd@...aro.org>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] device-tree: aqp8064.dtsi: Remove usb phy dr_mode =
 "host"

On Mon 08 Aug 15:34 PDT 2016, John Stultz wrote:

Changes in this file is commonly prefixed "ARM: dts: apq8064:", please
follow that. Perhaps:

ARM: dts: apq8064: Drop dr_mode property from usb phy

> Most 8064 devices have micro-usb ports for phy1, so setting
> the dr_mode to host here seems incorrect.
> 
> Leaving it unspecified should default to otg, and then
> any boards that wish to specify something else, can
> override it in their dts file.
> 
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Andy Gross <agross@...eaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Stephen Boyd <stephen.boyd@...aro.org>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> Signed-off-by: John Stultz <john.stultz@...aro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
>  arch/arm/boot/dts/qcom-apq8064.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 9dc83b0..7e43416 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -750,7 +750,6 @@
>  			reg		= <0x12500000 0x400>;
>  			interrupts	= <GIC_SPI 100 IRQ_TYPE_NONE>;
>  			status		= "disabled";
> -			dr_mode		= "host";
>  
>  			clocks		= <&gcc USB_HS1_XCVR_CLK>,
>  					  <&gcc USB_HS1_H_CLK>;
> -- 
> 1.9.1
>