linux-kernel - [PATCH 3/4] befs: remove the validation of allocation group number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7008e2c3fbeb855b1670487959f13ffb776ac31c.1470867071.git.salah.triki@gmail.com>
Date:	Wed, 10 Aug 2016 23:12:32 +0100
From:	Salah Triki <salah.triki@...il.com>
To:	akpm@...ux-foundation.org, viro@...iv.linux.org.uk,
	luisbg@....samsung.com
Cc:	linux-kernel@...r.kernel.org, salah.triki@...il.com
Subject: [PATCH 3/4] befs: remove the validation of allocation group number

Validating the allocation group number is unnecessary since it will
be done by iaddr2blockno().

Signed-off-by: Salah Triki <salah.triki@...il.com>
---
 fs/befs/io.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fs/befs/io.c b/fs/befs/io.c
index 14eef7d..f9790f5 100644
--- a/fs/befs/io.c
+++ b/fs/befs/io.c
@@ -28,18 +28,11 @@ befs_bread_iaddr(struct super_block *sb, befs_inode_addr iaddr)
 {
 	struct buffer_head *bh;
 	befs_blocknr_t block = 0;
-	struct befs_sb_info *befs_sb = BEFS_SB(sb);
 
 	befs_debug(sb, "---> Enter %s "
 		   "[%u, %hu, %hu]", __func__, iaddr.allocation_group,
 		   iaddr.start, iaddr.len);
 
-	if (iaddr.allocation_group > befs_sb->num_ags) {
-		befs_error(sb, "BEFS: Invalid allocation group %u, max is %u",
-			   iaddr.allocation_group, befs_sb->num_ags);
-		goto error;
-	}
-
 	block = iaddr2blockno(sb, &iaddr);
 
 	if (block == BEFS_ERR)
-- 
1.9.1