linux-kernel - Re: [LKP] [lkp] [xfs] 68a9f5e700: aim7.jobs-per-min -13.6% regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Aug 2016 17:23:59 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Huang, Ying" <ying.huang@...el.com>
Cc:	Dave Chinner <david@...morbit.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Bob Peterson <rpeterso@...hat.com>,
	Wu Fengguang <fengguang.wu@...el.com>, LKP <lkp@...org>,
	Christoph Hellwig <hch@....de>
Subject: Re: [LKP] [lkp] [xfs] 68a9f5e700: aim7.jobs-per-min -13.6% regression

On Wed, Aug 10, 2016 at 5:11 PM, Huang, Ying <ying.huang@...el.com> wrote:
>
> Here is the comparison result with perf-profile data.

Heh. The diff is actually harder to read than just showing A/B
state.The fact that the call chain shows up as part of the symbol
makes it even more so.

For example:

>       0.00 ± -1%      +Inf%       1.68 ±  1%  perf-profile.cycles-pp.__add_to_page_cache_locked.add_to_page_cache_lru.pagecache_get_page.grab_cache_page_write_begin.iomap_write_begin
>       1.80 ±  1%    -100.0%       0.00 ± -1%  perf-profile.cycles-pp.__add_to_page_cache_locked.add_to_page_cache_lru.pagecache_get_page.grab_cache_page_write_begin.xfs_vm_write_begin

Ok, so it went from 1.8% to 1.68%, and isn't actually that big of a
change, but it shows up as a big change because the caller changed
from xfs_vm_write_begin to iomap_write_begin.

There's a few other cases of that too.

So I think it would actually be easier to just see "what 20 functions
were the hottest" (or maybe 50) before and after separately (just
sorted by cycles), without the diff part. Because the diff is really
hard to read.

                 Linus