linux-kernel - Re: [PATCH] relay: Use per CPU constructs for the relay channel buffer pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160811070326.GA12148@nuc-i3427.alporthouse.com>
Date:	Thu, 11 Aug 2016 08:03:26 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	akash.goel@...el.com
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Tvrtko Ursulin <tvrtko.ursulin@...el.com>
Subject: Re: [PATCH] relay: Use per CPU constructs for the relay channel
 buffer pointers

On Thu, Aug 11, 2016 at 12:35:40PM +0530, akash.goel@...el.com wrote:
> From: Akash Goel <akash.goel@...el.com>
> 
> relay essentially needs to maintain the per CPU array of channel buffer
> pointers but it manually creates that array.
> Instead its better to avail the per CPU constructs, provided by the
> kernel, to allocate & access the array of pointer to channel buffers.
> 
> Cc: Chris Wilson <chris@...is-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@...el.com>
> Signed-off-by: Akash Goel <akash.goel@...el.com>

This has the benefit of being a mechnical change and I could not think
of a better way to express the per-cpu indirection.

relay.h should probably include <linux/percpu.h> so that it pulls in
the percpu api explicitly.

Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre