linux-kernel - Re: [PATCH 2/2] scripts/sortextable: set the variable mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Aug 2016 09:08:35 +0200
From:	Borislav Petkov <bp@...e.de>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	ard.biesheuvel@...aro.org, catalin.marinas@....com, bp@...e.de,
	deller@....de, will.deacon@....com, tony.luck@...el.com,
	linux-kernel@...r.kernel.org, ajeet.y@...sung.com,
	pankaj.m@...sung.com, Vaneet Narang <v.narang@...sung.com>
Subject: Re: [PATCH 2/2] scripts/sortextable: set the variable mmap_failure

On Thu, Aug 11, 2016 at 09:52:55AM +0530, Maninder Singh wrote:
> Currently mmap_failed variable is 1 for every case, so make it 0
> if mmap is success.
> 
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Signed-off-by: Vaneet Narang <v.narang@...sung.com>

See section 11) of Documentation/SubmittingPatches on how the sign-off
chain should be done.

It is not clear from your current submission what Vaneet's role is in
the creation of this patch is. Ditto for your other patch.

> ---
>  scripts/sortextable.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/sortextable.c b/scripts/sortextable.c
> index 30b4e7c..0b6a31b 100644
> --- a/scripts/sortextable.c
> +++ b/scripts/sortextable.c
> @@ -106,6 +106,7 @@ static void *mmap_file(char const *fname)
>  	}
>  	addr = mmap(0, sb.st_size, PROT_READ|PROT_WRITE, MAP_SHARED,
>  		    fd_map, 0);
> +	mmap_failed = 0;

This mmap_failed thing looks like a disaster. It is only needed so
that we know to do munmap() but munmap() works even if the range is
not mapped so you probably could go and remove that mmap_failed thing
altogether.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--