lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Aug 2016 18:00:20 -0700 (PDT) From: David Miller <davem@...emloft.net> To: grygorii.strashko@...com Cc: netdev@...r.kernel.org, mugunthanvnm@...com, nsekhar@...com, linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org, catalin.marinas@....com Subject: Re: [PATCH v2] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers From: Grygorii Strashko <grygorii.strashko@...com> Date: Wed, 10 Aug 2016 20:02:53 +0300 > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index 0805855..5caef77 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -732,6 +732,11 @@ static void cpsw_rx_handler(void *token, int len, int status) > netif_receive_skb(skb); > ndev->stats.rx_bytes += len; > ndev->stats.rx_packets++; > + /* SKB pointer will be stored in CPPI RAM (SRAM) which belongs > + * to MMIO space, as result false positive memory leak report > + * will be generated. > + */ > + kmemleak_not_leak(new_skb); > } else { > ndev->stats.rx_dropped++; > new_skb = skb; There is already a kmemleak_not_leak() statement here in the current driver. Please always develop and generate patches against current sources.
Powered by blists - more mailing lists