linux-kernel - Re: [PATCH 1/2] ahci: st: Add ports-implemented property in support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72e008b8-25dd-ae87-fd8c-b9e60b6fb1a8@cogentembedded.com>
Date:	Thu, 11 Aug 2016 14:04:17 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	patrice.chotard@...com, Tejun Heo <tj@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	kernel@...inux.com
Subject: Re: [PATCH 1/2] ahci: st: Add ports-implemented property in support

On 8/10/2016 6:37 PM, patrice.chotard@...com wrote:

> From: Patrice Chotard <patrice.chotard@...com>
>
> Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL
> returns 0. So force_port_map to 1 by using ports-implemented
> DT property.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@...com>
> ---
>  drivers/ata/ahci_st.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
> index 8ff428f..bc345f2 100644
> --- a/drivers/ata/ahci_st.c
> +++ b/drivers/ata/ahci_st.c
> @@ -147,6 +147,7 @@ static struct scsi_host_template ahci_platform_sht = {
>
>  static int st_ahci_probe(struct platform_device *pdev)
>  {
> +	struct device *dev = &pdev->dev;

    Why? You could just use 'pdev'.

>  	struct st_ahci_drv_data *drv_data;
>  	struct ahci_host_priv *hpriv;
>  	int err;
> @@ -170,6 +171,9 @@ static int st_ahci_probe(struct platform_device *pdev)
>
>  	st_ahci_configure_oob(hpriv->mmio);
>
> +	of_property_read_u32(dev->of_node,

    pdev->dev.of_node

> +			     "ports-implemented", &hpriv->force_port_map);
> +
>  	err = ahci_platform_init_host(pdev, hpriv, &st_ahci_port_info,
>  				      &ahci_platform_sht);
>  	if (err) {

MBR, Sergei