linux-kernel - Re: [PATCH] perf tools mem: Fix -t store option for record command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160811115138.GB27651@kernel.org>
Date:	Thu, 11 Aug 2016 08:51:38 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Michael Petlan <mpetlan@...hat.com>
Subject: Re: [PATCH] perf tools mem: Fix -t store option for record command

Em Thu, Aug 11, 2016 at 10:50:57AM +0200, Jiri Olsa escreveu:
> Michael reported 'perf mem -t store record' being broken.
> The reason is latest rework of this area:
>   commit acbe613e0c03 ("perf tools: Add monitored events array")
> 
> We don't mark perf_mem_events store record when -t store
> option is specified.
> 
> Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array")
         ^^^^^^
I'll remove this extraneous bit

> Reported-by: Michael Petlan <mpetlan@...hat.com>
> Link: http://lkml.kernel.org/n/tip-dbytnk7urdnnaw7ckdu1w7lq@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> ---
>  tools/perf/builtin-mem.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
> index d608a2c9e48c..d1ce29be560e 100644
> --- a/tools/perf/builtin-mem.c
> +++ b/tools/perf/builtin-mem.c
> @@ -88,6 +88,9 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
>  	if (mem->operation & MEM_OPERATION_LOAD)
>  		perf_mem_events[PERF_MEM_EVENTS__LOAD].record = true;
>  
> +	if (mem->operation & MEM_OPERATION_STORE)
> +		perf_mem_events[PERF_MEM_EVENTS__STORE].record = true;
> +
>  	if (perf_mem_events[PERF_MEM_EVENTS__LOAD].record)
>  		rec_argv[i++] = "-W";
>  
> -- 
> 2.4.11